Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program for calculator #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

program for calculator #60

wants to merge 2 commits into from

Conversation

1abhi23
Copy link

@1abhi23 1abhi23 commented Oct 11, 2018

No description provided.

scanf("%lf",&num2);
switch(op){
case 1:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary Spacing.

printf("=%lf\n", num1*num2);
break;
case 4:
if(num2==0){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of curly braces


printf("Enter second number\n");
scanf("%lf",&num2);
switch(op){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper indentation

@AkshayCHD
Copy link
Contributor

@1abhi23 good work with the PR, but we have to make sure that the code we merge is proper, so please make the necessary changes and push again. Also claim the issue that you are working on in the issues section. So that no one else works in it till the time you do.

Copy link
Contributor

@divyam3897 divyam3897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you added two files? Review comments are still not addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants