Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#37 #85

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Issue#37 #85

wants to merge 8 commits into from
+16 −0

Conversation

PavitKaur05
Copy link
Contributor

@PavitKaur05 PavitKaur05 commented Oct 18, 2018 •
edited
Loading

#37
Program to calculate factorial of a number in c++.

@PavitKaur05
Copy link
Contributor Author

I just wanted to put pull request of my added program but the changes of my prev pull request has also been added and I don't how to avoid that . Please help me with this thing and in case of program I have added all its files and let me know that whether i just have to put up main,cpp.
@mahirgupta @gurpreetsingh00885 @AkshayCHD

AkshayCHD
AkshayCHD requested changes Oct 23, 2018
View reviewed changes
introduction/Pavit/Issue#37/Issue#37.cbp Outdated
@@ -0,0 +1,43 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted the file now

introduction/Pavit/Issue#37/main.cpp Outdated
#include <iostream>

using namespace std;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper indentation

Copy link
Contributor Author

@PavitKaur05 PavitKaur05 Oct 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated file with indentation. Please review it again @AkshayCHD

introduction/Pavit/about.md.txt Outdated
@@ -0,0 +1,11 @@
# Introduction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant to the issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this but i am not getting how its being added again in new pull request

AkshayCHD
AkshayCHD requested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@AkshayCHD AkshayCHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these binary files, and put your program in programs directory in respective folders

@PavitKaur05
Copy link
Contributor Author

I am unable to remove binary files as i do not find any such option along with them and another question is that do i need to open new pull request for adding this program in program directory??
@AkshayCHD

divyam3897
divyam3897 requested changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@divyam3897 divyam3897 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to delete these files, no need for a separate PR. You should modify the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyam3897 divyam3897 divyam3897 requested changes

@AkshayCHD AkshayCHD AkshayCHD requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PavitKaur05 @divyam3897 @AkshayCHD