base.html: Improve navbar #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyam3897
requested changes
Oct 11, 2017
divyam3897
requested changes
Oct 12, 2017
There was a problem hiding this comment.
Changes:
- If I click on about us nothing happens, increase the size of the section so hat one reaches about us.
- If I go to resources and click on about us nothing happens. (user should land at about us)
- About us should be before resources in navbar
- This is how it looks in small screen sizes which is not at all good http://picpaste.com/Screenshot_20171012_155634-L6uq79tb.png
|
@sagar-kalra still on it? |
|
@divyam3897 yeah, I ll complete it. |
|
Ignore this commit |
|
@divyam3897 I have designed the navbar, but i am not able to link about us. |
divyam3897
requested changes
Oct 19, 2017
templates/base.html
Outdated
| <div class="loader-rect3"></div> | ||
| <div class="loader-rect4"></div> | ||
| <div class="loader-rect5"></div> | ||
| <div class="loader-rect1"></div> |
sagar-kalra
force-pushed
the
navbar
branch
2 times, most recently
from
dde18e5 to
b43159a
Compare
divyam3897
requested changes
Oct 25, 2017
| .jumbotron h1{ | ||
| font-size: 6.2vw !important; | ||
| } | ||
|
|
templates/base.html
Outdated
| <div class="loader-rect3"></div> | ||
| <div class="loader-rect4"></div> | ||
| <div class="loader-rect5"></div> | ||
| <div class="loader-rect1"></div> |
divyam3897
requested changes
Oct 25, 2017
There was a problem hiding this comment.
http://picpaste.com/Screenshot_20171026_030441-mvgwxmwX.png I would centre it and remove the scroll.
sagar-kalra
force-pushed
the
navbar
branch
2 times, most recently
from
8e7087f to
cf76f50
Compare
Add a new page for aboutus and made necessary change in urls and views. Closes pclubuiet#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve navbar and add navstyle.css for styling
Fixes #2 .