Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo in README #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
632e899
Fix SDK path environment variable typo
May 29, 2024
29599a2
Add context to pdc command error
May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This software is not sponsored or supported by Panic.

## Requirements

* The Playdate SDK installed in `$HOME/Developer/PlaydateSDK` on Linux or MacOS, `$HOME/Documents/PlaydateSDK` on Window, or at the path specified by the `$PLAYDATE_SDK` environment variable.
* The Playdate SDK installed in `$HOME/Developer/PlaydateSDK` on Linux or MacOS, `$HOME/Documents/PlaydateSDK` on Window, or at the path specified by the `$PLAYDATE_SDK_PATH` environment variable.
* Rust, easiest installed via [rustup](https://rustup.rs).
* Switch to the nightly toolchain using `rustup toolchain install nightly`, required for the `build-std` feature.
* If you want to build for the Playdate device, you will need the `thumbv7em-none-eabihf` target. Added with `rustup +nightly target add thumbv7em-none-eabihf`
Expand Down
4 changes: 2 additions & 2 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ use structopt::StructOpt;
use zip::{write::FileOptions, CompressionMethod};
use zip_extensions::zip_create_from_directory_with_options;

#[cfg(unix)]
use anyhow::Context;

#[cfg(target_os = "linux")]
Expand Down Expand Up @@ -378,7 +377,8 @@ impl Build {
let status = cmd
.stdout(std::process::Stdio::piped())
.stderr(std::process::Stdio::piped())
.status()?;
.status()
.with_context(|| format!("Command failed: {cmd:?}"))?;
if !status.success() {
bail!("pdc failed with error {:?}", status);
}
Expand Down
Loading