Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow strategy to be called on arbitrary classes #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/flip/abstract_strategy.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
module Flip
class AbstractStrategy

def initialize(_model_class = nil)
end

def name
self.class.name.split("::").last.gsub(/Strategy$/, "").underscore
end
Expand Down
2 changes: 1 addition & 1 deletion lib/flip/declarable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def feature(key, options = {})

# Adds a strategy for determining feature status.
def strategy(strategy)
FeatureSet.instance.add_strategy strategy
FeatureSet.instance.add_strategy strategy, self
end

# The default response, boolean or a Proc to be called.
Expand Down
4 changes: 2 additions & 2 deletions lib/flip/feature_set.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def << definition
end

# Adds a strategy for determing feature status.
def add_strategy(strategy)
strategy = strategy.new if strategy.is_a? Class
def add_strategy(strategy, klass = nil)
strategy = strategy.new(klass) if strategy.is_a? Class
@strategies[strategy.name] = strategy
end

Expand Down
15 changes: 15 additions & 0 deletions spec/declarable_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,26 @@
it { should_not be_on(:one) }
it { should be_on(:three) }
end

context "with default set to true" do
before { model_class.send(:default, true) }
it { should be_on(:one) }
it { should be_on(:three) }
end
end

describe "the .strategy class method" do
let!(:model_class) do
Class.new do
extend Flip::Declarable
end
end

it "passes the class it's on" do
expect(Flip::DeclarationStrategy).to receive(:new)
.with(model_class)
.and_call_original
model_class.strategy Flip::DeclarationStrategy
end
end
end