fix(core/pipeline): Disable pipeline sorting when filtering by name (…

…because some pipelines are hidden)
pdk27 · Jul 30, 2021 · 1e06186 · 1e06186
1 parent 9cc7807
commit 1e06186
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/packages/core/src/pipeline/filter/ExecutionFilters.tsx b/packages/core/src/pipeline/filter/ExecutionFilters.tsx
@@ -164,6 +164,9 @@ export class ExecutionFilters extends React.Component<IExecutionFiltersProps, IE
       newPipelineNames = newPipelineNames.filter((pipelineName) =>
         pipelineName.toLocaleLowerCase().includes(searchString.toLocaleLowerCase()),
       );
+      if (this.state.pipelineReorderEnabled) {
+        this.disablePipelineReorder();
+      }
     }
     const newStrategyNames = this.getPipelineNames(true);
     if (!isEqual(pipelineNames, newPipelineNames) || !isEqual(strategyNames, newStrategyNames)) {
@@ -268,14 +271,22 @@ export class ExecutionFilters extends React.Component<IExecutionFiltersProps, IE
                 {pipelineNames.length > 0 && (
                   <div>
                     {!pipelineReorderEnabled && (
-                      <a className="btn btn-xs btn-default clickable" onClick={this.enablePipelineReorder}>
+                      <button
+                        className="btn btn-xs btn-default"
+                        onClick={this.enablePipelineReorder}
+                        disabled={Boolean(searchString)}
+                      >
                         Reorder Pipelines
-                      </a>
+                      </button>
                     )}
                     {pipelineReorderEnabled && (
-                      <a className="btn btn-xs btn-default clickable" onClick={this.disablePipelineReorder}>
+                      <button
+                        className="btn btn-xs btn-default"
+                        onClick={this.disablePipelineReorder}
+                        disabled={Boolean(searchString)}
+                      >
                         Done
-                      </a>
+                      </button>
                     )}
                   </div>
                 )}