-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new command option to set env file for pdm script #3358
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
+ Coverage 85.21% 85.24% +0.02%
==========================================
Files 112 112
Lines 11461 11472 +11
Branches 2505 2507 +2
==========================================
+ Hits 9767 9779 +12
+ Misses 1168 1167 -1
Partials 526 526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manjusaka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to suggest some improvements
The env files can be cascaded in a way that more specific env file can override less specific ones. For example, if PDM_ENVIRONMENT=prod
, we look for the following files and load them if exists:
.env
(effective for all environments).env.prod
(effective forprod
only).env.local
(effective for all environments).env.prod.local
(effective forprod
only)
The variables are merged in the above order, with the latter taking precedence.
The improvement is to make .local
a special modifier rather than a regular environment name. It contains the env vars for the current machine only, and .env*.local
should be added to the .gitignore
, while other .env
files can be shared safely.
Also happy to hear @noirbizarre 's thoughts since he is the one involved in PDM scripts the most.
Nice idea! I will update it ASAP |
Pull Request Checklist
news/
describing what is new.Describe what you have changed in this PR.
Fix #3355