Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiching to the latest release of nixpkgs 23.11 from unstable. #105

Merged

Conversation

RobbieBuxton
Copy link
Collaborator

What is it

With the new release of NixOS 23.11 "Tapir" we now have a sufficient version of containerd (>= 1.73) to pin nix-snapshotter back to a stable branch.

Change 1

There has been a change in NixOS user-groups that causes the current version of the vm demo not to work.

Steps to reproduce

  • run on the main branch nix run .#vm --recreate-lock-file

output log

[robbieb@nixos:~/PDT/nix-snapshotter]$ nix run .#vm --recreate-lock-file
       error:
       Failed assertions:
       - The following users have a primary group that is undefined: rootless
       Hint: Add this to your NixOS configuration:
         users.groups.rootless = {};

Fix

Added the suggested line to vm.nix. Open to suggestions if there is a cleaner way of fixing this.

Change 2

vendorSha256 has been deprecated and replaced with vendorHash

Problems

Currently there is a broken dependency, certmgr-selfsigned in nix-snapshotter causing the build to fail.

Steps to reproduce

output log

[robbieb@nixos:~]$ nix run .#vm 
error: hash mismatch in fixed-output derivation '/nix/store/chw7m5ssvzqgzasd6nvyfik79z4plm43-cloudflare-certmgr-pull-51.patch.drv':
         specified: sha256-OmOz6CeO1GTZ5NIVqhhnJWNP5K7X2LX28q+KlkrgGko=
            got:    sha256-0TEvUWH+ybtLiNxJAcpq7mThQzU6iQ1ykYVcikAyhVI=
error: 1 dependencies of derivation '/nix/store/38zbnb57frmlxvxwr67d7qi40755flyv-certmgr-1.6.4.drv' failed to build
error: 1 dependencies of derivation '/nix/store/ppj512ljfi97fljrdxblz2q5r78a47c2-unit-certmgr.service.drv' failed to build
error: 1 dependencies of derivation '/nix/store/si880vj0j5dk3p8m6lx7zh4s76lp086a-system-units.drv' failed to build
error: 1 dependencies of derivation '/nix/store/n7wb45awad18zv8ppa3rpyqr5781bymm-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fir2l21shn1shjhdpi0fjdympc0yvkhg-nixos-system-nixos-23.11.20231129.50aa30a.drv' failed to build
error: 1 dependencies of derivation '/nix/store/dcn4g8s2hi63gw3k0309knbihh27zvkp-nixos-vm.drv' failed to build

Cause

This is caused by an upstream bug in nixpkgs which I have raised an issue to fix, hopefully once this is merged this PR should be ready to merge.

@RobbieBuxton RobbieBuxton marked this pull request as ready for review November 30, 2023 22:44
@RobbieBuxton RobbieBuxton marked this pull request as draft November 30, 2023 22:44
@RobbieBuxton
Copy link
Collaborator Author

The issue has been fixed and merged into nixos-master but has yet to be merged into nixos-unstable. The progress can be tracked here: https://nixpk.gs/pr-tracker.html?pr=271299

@RobbieBuxton
Copy link
Collaborator Author

The fix is now in nixos-unstable.

jcaesar pushed a commit to jcaesar/sysflake that referenced this pull request Dec 18, 2023
 - pdtpartners/nix-snapshotter#105
 -  pathway /var/lib/kubernetes/secrets/ca.pem is already managed by spec /nix/store/7bww6a4adgzk3fqiv96mm95dij77d96n-certmgr.d/addonManager.json"
… and added user.group.rootless to vm"

Signed-off-by: Robbie Buxton <[email protected]>
@RobbieBuxton RobbieBuxton marked this pull request as ready for review January 9, 2024 18:45
@RobbieBuxton
Copy link
Collaborator Author

RobbieBuxton commented Jan 9, 2024

The fix was successfully backported into 23.11 and is ready for review/testing @elpdt852 @gbpdt

@elpdt852 elpdt852 added the ok-to-test Runs NixOS tests label Jan 9, 2024
Copy link
Collaborator

@elpdt852 elpdt852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RobbieBuxton, changes look good to me and I appreciate all the links & context.

@RobbieBuxton
Copy link
Collaborator Author

@elpdt852 Thanks for the review! I don't think I have permission to merge so I think you might need to do it.

@elpdt852 elpdt852 merged commit 67370cd into pdtpartners:main Jan 9, 2024
13 checks passed
@RobbieBuxton RobbieBuxton deleted the feature/pin-nixpkgs-to-23-11 branch January 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants