Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s: use default buildGoModule [V2] #139

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

RobbieBuxton
Copy link
Collaborator

Finishing off the PR @ck3d opened. We can patch k3s to fix the go 120+ build issue and remove the dependency on the deprecated go builder.

…0+ compat issue

Signed-off-by: Robbie <[email protected]>

Co-authored-by: Christian Kögler <[email protected]>
@RobbieBuxton RobbieBuxton added the ok-to-test Runs NixOS tests label May 11, 2024
@ck3d
Copy link
Contributor

ck3d commented May 11, 2024

Thanks for taking over!

@RobbieBuxton
Copy link
Collaborator Author

Thanks for taking over!

Thanks for spotting it!

hinshun
hinshun approved these changes May 11, 2024
Copy link
Collaborator

@elpdt852 elpdt852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 🙏

@RobbieBuxton RobbieBuxton merged commit 7b251c9 into main May 11, 2024
26 checks passed
@RobbieBuxton RobbieBuxton deleted the switch-default-gobuild branch May 11, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants