Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update modules to nixos 24.05 and k3s 1.30 #141

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Jun 9, 2024

No description provided.

@bglgwyng
Copy link
Contributor

I encountered this error message.

error:
       … while calling the 'head' builtin

         at /nix/store/0jr2kk95c34c0b6yxi75q4fqgb43kqkm-source/lib/attrsets.nix:1575:11:

         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … while evaluating the attribute 'value'

         at /nix/store/0jr2kk95c34c0b6yxi75q4fqgb43kqkm-source/lib/modules.nix:821:9:

          820|     in warnDeprecation opt //
          821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          822|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute '"sha256-Mj9Q3TgqZoJluG4/nyuw2WHnB3OJ+/mlV7duzWt1B1A="' missing

       at /nix/store/3wy0ggfkfzma1hadbfy9b3jgn6272csz-source/modules/flake/overlays.nix:12:24:

           11|         buildGoModule = args: super.buildGoModule (args // super.lib.optionalAttrs (args.pname != "k3s-cni-plugins" && args.pname != "k3s-containerd") {
           12|           vendorHash = {
             |                        ^
           13|             "sha256-XtTahFaWnuHzKDI/U4d/j4C4gRxH163MCGEEM4hu/WM=" = "sha256-XuMP+ffwTdXKL9q9+ZJUQc5ghGEcdY9UdefjCD19OUE=";

Here is my flake.lock

@yu-re-ka
Copy link
Contributor Author

you can just add "sha256-Mj9Q3TgqZoJluG4/nyuw2WHnB3OJ+/mlV7duzWt1B1A=" = lib.fakeHash to the list, then see what it gives you as "expected" and enter that instead of lib.fakeHash

@RobbieBuxton RobbieBuxton added the ok-to-test Runs NixOS tests label Aug 12, 2024
@RobbieBuxton RobbieBuxton self-requested a review August 12, 2024 12:30
Copy link
Collaborator

@RobbieBuxton RobbieBuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yu-re-ka,
Sorry for taking so long to get around to looking at this, it’s been a busy couple of months! Thanks again for the contributions!

modules/flake/overlays.nix Show resolved Hide resolved
Copy link
Collaborator

@RobbieBuxton RobbieBuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm happy with this, if @elpdt852 is as well I think this is ready to merge!

@elpdt852 elpdt852 merged commit b4cd262 into pdtpartners:main Aug 15, 2024
20 checks passed
@elpdt852
Copy link
Collaborator

elpdt852 commented Aug 15, 2024

Awesome, you even updated the nix-snapshotter patch to k3s. Thanks @yu-re-ka !

@bglgwyng
Copy link
Contributor

@yu-re-ka Thanks! your solution worked!

"sha256-Mj9Q3TgqZoJluG4/nyuw2WHnB3OJ+/mlV7duzWt1B1A=" = "sha256-9i0vY+CqrLDKYBZPooccX7OtFhS3//mpKTLntvPYDJo=";

I don't know well about vendorHash attribute in buildGoModule, but isn't it worth making PR to add this code? If then, I'll do it.

@yu-re-ka
Copy link
Contributor Author

@bglgwyng yes it makes sense to make a PR. Please specify the exact version of nixpkgs you are using in the PR, so that others can check the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants