-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Travis tests to GitHub actions #16
base: master
Are you sure you want to change the base?
Conversation
The test suite itself is not changed. For now we test only on Ubuntu and macOS because we need sudo.
@duboism: Good job! |
Just to know: did you try to run the actions ? |
While paying a bit more attention to the test output, I noticed that PHPUnit warns about some deprecated code (namely, the dynamic creation of a property which is deprecated since PHP 8.2). I will address that in another PR. There is another deprecation: the XML configuration file for PHPUnit changed in version 10. I guess this should be addressed at some point too. |
@pear ? |
By the way, I realized that some pear packages (like pear/pear-core) already moved to GitHub actions. AFAICS, the actions are similar to what I propose here but if somebody knows better, don't hesitate. |
The file is deprecated for recent PHPUnit.
6f85416
to
ca1c19c
Compare
I removed the configuration file and updated the actions. |
Travis no longer gives free access to free projects. Therefore, this PR convert to the test suite to GitHub actions.
Technical details
Here are a few notes:
pear
must be run withsudo
. Therefore, for now, we test only on Ubuntu and macOS because there is nosudo
on Windows.Actions
tab, selectMain
on the left and in the drop box, select branchgithub_actions_master
and then click theRun workflow
button.Relation to #15 and #17
As of 2186e20, #15 is a bit buggy (conflicts in versions of
PHPUnit
).This PR was developed to simplify the development of #15 but since then I found a better approach to modernize the test suite which is in #17.
#17 is based on this branch so merging this would greatly help.