Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing two tags to have the same value #15

Closed
wants to merge 1 commit into from

Conversation

Maturion
Copy link

@Maturion Maturion commented Mar 1, 2017

The following change would remove the check that's preventing two tags from having the same value (as described at #14 )

The following change would remove the check that's preventing two tags from having the same value (as described at pear#14 )
@kenguest
Copy link
Member

kenguest commented Mar 6, 2017

Please provide sample code that proves the flaw that your pull request addresses does actually happen - I still can't reproduce it. See below:

$ php test.php 
/home/kguest/dev/code/Services_Openstreetmap/examples/test.php:28:
array(5) {
  'barrier' =>
  string(9) "lift_gate"
  'bicycle' =>
  string(3) "yes"
  'foot' =>
  string(3) "yes"
  'motorcar' =>
  string(3) "yes"
  'motorcycle' =>
  string(3) "yes"
}
/home/kguest/dev/code/Services_Openstreetmap/examples/test.php:30:
array(6) {
  'barrier' =>
  string(9) "lift_gate"
  'bicycle' =>
  string(3) "yes"
  'foot' =>
  string(3) "yes"
  'motorcar' =>
  string(3) "yes"
  'motorcycle' =>
  string(3) "yes"
  'horse' =>
  string(3) "yes"
}
$ cat test.php 
<?php    
$version = '@package_version@';
if (strstr($version, 'package_version')) {
    set_include_path(
        dirname(dirname(__FILE__)) . PATH_SEPARATOR . get_include_path()
    );
}

require_once 'Services/OpenStreetMap.php';

$osm = new Services_OpenStreetMap();

$node = $osm->getNode(401839334);
var_dump($node->getTags());
$node->setTag('horse', 'yes');
var_dump($node->getTags());

@CloCkWeRX
Copy link
Member

Closing, given the conflicts and no feedback

@CloCkWeRX CloCkWeRX closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants