Toward boundary gradient fix: part 1 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, parts of GradNonLinearForm and GradFaceIntegrator had _GPU_ specific code that was superseded by device-specific code in the Gradients class and thus was never called. This code has been eliminated to improve hygiene in preparation for changes to address #198.
In preparation for further refactoring as part of addressing #198
The idea here is to take advantage of all the data that has already been set up in class BCIntegrator by making class GradFaceIntegrator its friend. Then we can use the internal std::unordered_map objects in BCIntegrator, which map the boundary attribute to the appropriate BoundaryCondition class, to get access to any required boundary condition information. In principle that is all that is necessary, but the data we need it is not in a convenient form. To address this, the method computeBdrPrimitiveStateForGradient has been added to the BoundaryCondition class. In the base class, this method just sets the boundary state to the internal state, which results in the same (incorrect) behavior we have now. In future commits, this method will be implemented in the children of BoundaryCondition in order to provide the right boundary state.
) Eventually useBCinGrad = true will be the default (and only) option. But, during development, it is useful to be able to turn it off so we can ensure we don't introduce any unintended effects by running the regression tests (which will have to have their 'truth' solutions regenerated once this change is ready.
(but only when using recent mods to account for BC in gradient)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step toward #198. Specifically, we begin to put in the machinery that is necessary on the cpu path and implement it for an isothermal wall. Additional bcs as well as gpu support will come later.