Skip to content

Commit

Permalink
fix: Dropdown issue that py value is not applied when the value is 0 (#…
Browse files Browse the repository at this point in the history
…883)

* fix: issue that py value is not applied when the value is 0

* feat: apply review
  • Loading branch information
boulder-101 authored Nov 1, 2023
1 parent f3d7cc1 commit c85ca23
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/vibrant-components/src/lib/Dropdown/Dropdown.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable max-lines */
import type { Align, Side } from 'packages/vibrant-utils/src/types';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import {
Expand Down Expand Up @@ -264,7 +265,7 @@ export const Dropdown = withDropdownVariation(
<Box alignSelf="flex-start">
<Box
backgroundColor="surface2"
py={py ? py : CONTENT_PADDING}
py={isDefined(py) ? py : CONTENT_PADDING}
elevationLevel={4}
rounded="md"
minWidth={[280, 280, 240]}
Expand Down

1 comment on commit c85ca23

@vercel
Copy link

@vercel vercel bot commented on c85ca23 Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boulder-101 is attempting to deploy a commit to the Class101 Team on Vercel.

To accomplish this, @boulder-101 needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Please sign in to comment.