chore: can use aspect ratio value as string (#922)

* feat: can use aspect ratio value as string * test: add timeout seconds
pedaling · Dec 28, 2023 · d60eb02 · d60eb02 · vercel · Dec 28, 2023
1 parent fc56ec6
commit d60eb02
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/vibrant-components/src/lib/Drawer/Drawer.spec.tsx b/packages/vibrant-components/src/lib/Drawer/Drawer.spec.tsx
@@ -85,7 +85,7 @@ describe('<Drawer />', () => {
     });
 
     it('content size is shrink', async () => {
-      await waitFor(() => expect(computedStyle.width).toEqual('480px'), { timeout: 2000 });
+      await waitFor(() => expect(computedStyle.width).toEqual('480px'), { timeout: 5000 });
     });
   });
 

diff --git a/packages/vibrant-core/src/lib/props/sizing/sizing.ts b/packages/vibrant-core/src/lib/props/sizing/sizing.ts
@@ -30,7 +30,7 @@ const boxSizingProp = createSystemProp({
 
 const aspectRatioProp = createSystemProp({
   property: 'aspectRatio',
-  transform: (value: number) => ({
+  transform: (value: number | string) => ({
     aspectRatio: value ? value.toString() : value,
   }),
 });

diff --git a/packages/vibrant-core/src/lib/props/sizing/type.ts b/packages/vibrant-core/src/lib/props/sizing/type.ts
@@ -8,5 +8,5 @@ export type SizingSystemProps = {
   minHeight?: ResponsiveValue<number | string | 'auto' | 'fit-content' | 'max-content' | 'min-content'>;
   maxHeight?: ResponsiveValue<number | string | 'auto' | 'fit-content' | 'max-content' | 'min-content' | 'none'>;
   boxSizing?: 'border-box' | 'content-box';
-  aspectRatio?: ResponsiveValue<number>;
+  aspectRatio?: ResponsiveValue<number | string>;
 };
-Original file line number
+Diff line change
@@ Expand Up / @@ -85,7 +85,7 @@ describe('<Drawer />', () => { @@
         });
         it('content size is shrink', async () => {
-          await waitFor(() => expect(computedStyle.width).toEqual('480px'), { timeout: 2000 });
+          await waitFor(() => expect(computedStyle.width).toEqual('480px'), { timeout: 5000 });
         });
       });
@@ Expand Down @@