Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tabview crash when change childrenElement #949

Merged
merged 8 commits into from
Jul 10, 2024
Merged

Conversation

ssong10
Copy link
Contributor

@ssong10 ssong10 commented Mar 21, 2024

TabView 에 childrenElement 가 변경이 있을때, 내부에서 변경되지 않아서 발생하는 이슈를 수정하였습니다.

@ssong10 ssong10 requested a review from a team March 21, 2024 08:44
Copy link

vercel bot commented Mar 21, 2024

@ssong10 is attempting to deploy a commit to the Class101 Team on Vercel.

To accomplish this, @ssong10 needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@ssong10 ssong10 changed the title fix: tabview children element fix: tabview crash when change childrenElement Mar 21, 2024
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opensource ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 7:43am

@coveralls
Copy link

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9870137119

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 77.645%

Totals Coverage Status
Change from base Build 9841310466: 0.05%
Covered Lines: 4126
Relevant Lines: 5174

💛 - Coveralls

@ssong10 ssong10 enabled auto-merge (squash) July 10, 2024 07:39
@ssong10 ssong10 merged commit c2aba3d into main Jul 10, 2024
4 of 5 checks passed
@ssong10 ssong10 deleted the fix/tabview/children branch July 10, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants