Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 팝오버의 포지션 값에 애니메이션이 적용되지 않게 수정한다 #954

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: 팝오버의 포지션 값에 애니메이션이 적용되지 않게 수정한다 #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/vibrant-components/src/lib/Popover/Popover.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ export const Basic: ComponentStory<typeof Popover> = props => (
</VStack>
);

export const WithDefaultOpen: ComponentStory<typeof Popover> = props => (
<VStack width="100%" height="100vh" alignVertical="center" alignHorizontal="center">
<Popover title="Popover" {...props} open={true}>
<Popover.Opener openInteraction="click">
<Avatar size="lg" src="" alt="" />
</Popover.Opener>
</Popover>
</VStack>
);

export const WithExternalState: ComponentStory<typeof Popover> = props => {
const [isOpen, setIsOpen] = useState(false);

Expand Down
2 changes: 1 addition & 1 deletion packages/vibrant-components/src/lib/Popover/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ export const Popover = ({
<Transition
animation={{
opacity: isOpen && (popoverPosition.x !== 0 || popoverPosition.y !== 0) ? 1 : 0,
...popoverPosition,
}}
style={popoverPosition}
duration={200}
easing="easeOutQuad"
>
Expand Down
Loading