Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 스쿨 아이콘을 svg를 변경한다 #961

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feat: 스쿨 아이콘을 svg를 변경한다 #961

merged 1 commit into from
Jul 16, 2024

Conversation

jhn3981
Copy link
Collaborator

@jhn3981 jhn3981 commented Jul 16, 2024 •
edited
Loading

Before

image

After

image

@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opensource ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 10:43am

@jhn3981 jhn3981 requested review from a team, bae-unidev and white-101 July 16, 2024 05:49
kang-heewon
kang-heewon previously approved these changes Jul 16, 2024
View reviewed changes
pott-101
pott-101 previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@pott-101 pott-101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 🙇‍♂️

@jhn3981 jhn3981 enabled auto-merge (squash) July 16, 2024 05:58
@jhn3981 jhn3981 disabled auto-merge July 16, 2024 05:58
@coveralls
Copy link

coveralls commented Jul 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9955338946

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.645%
Totals Coverage Status
Change from base Build 9871040791: 0.0%
Covered Lines: 4126
Relevant Lines: 5174
💛 - Coveralls

@jhn3981 jhn3981 dismissed stale reviews from pott-101 and kang-heewon via 1ecc04d July 16, 2024 09:21
@jhn3981 jhn3981 enabled auto-merge (squash) July 16, 2024 09:22
@jhn3981 jhn3981 requested a review from kang-heewon July 16, 2024 09:22
@jhn3981 jhn3981 merged commit c66efe1 into main Jul 16, 2024
4 of 5 checks passed
@jhn3981 jhn3981 deleted the KTLO-129 branch July 16, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kang-heewon kang-heewon kang-heewon approved these changes

@pott-101 pott-101 pott-101 left review comments

@bae-unidev bae-unidev Awaiting requested review from bae-unidev bae-unidev was automatically assigned from pedaling/eng

@white-101 white-101 Awaiting requested review from white-101 white-101 was automatically assigned from pedaling/eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhn3981 @coveralls @kang-heewon @pott-101