Include option, feature request #12 #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why the test failed... it does pass on my computer for both the original and updated code :( |
|
Thanks for the contribution. I will make the code review during the week and try to see why tests are failing. At some point, we already had the situation that tests were failing on Travis and were passing locally. |
|
Squashed and merged with master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and implemented an include option, mutually exclusive with the ignore option, addressing the feature request #12 - I also updated the readme and the tests (also tested in our project where we use the plugin). This is my first attempt at creating a pull-request in github so please bear with me - I hope this is the correct process and that the code changes meet your standards.