Feature: Add membership notifications on interface #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pedrofran12 No sure if this feature is interesting or if is the good way to go with it but I thought it could be handy. Also MulticastRouterNotifier requires implementing 4 methods where only one was required for MulticastGroupNotifier so writing a interface may be useful here. |
leoplo
force-pushed
the
feature_add_router_notification
branch
3 times, most recently
from
baaae9b to
32d6271
Compare
leoplo
force-pushed
the
feature_add_router_notification
branch
from
32d6271 to
050a658
Compare
pedrofran12
reviewed
Jan 7, 2024
Owner
pedrofran12
left a comment
pedrofran12
left a comment
There was a problem hiding this comment.
Question: On the notify_report, notify_timeout and notify_done the lock should also be used? in order to prevent those methods to iterate over the list and concurrently the list increase/decrease in size in case notifiers are added or removed concurrent to the notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to get notify as it is done for GroupState when receiving report or done message.