-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active color opacity level & gradient option #80
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 96.87% 91.78% -5.10%
==========================================
Files 1 1
Lines 64 73 +9
==========================================
+ Hits 62 67 +5
- Misses 2 6 +4
Continue to review full report at Codecov.
|
Hi @annasimoniaine |
@pedromassango have you had a chance to look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @annasimoniaine
Thank you so much for this PR.
Can you please assert that both activeColor
and activeBackgroundColorGradient
most not be provided? User must be able to provide only one of them.
A test would also be required to merge this PR to make this does not break in the future.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate
Hi @pedromassango I added the assert and a test. Let me know if I need to add anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR, this should get merged soon.
Hello @pedromassango, and thanks @annasimoniaine :) I'm quite interested in this one, will you merge soon? Using
for now but don't like to depends on git for pubs ;) |
Added the option to set opacity level for the active color. Same changes as the first commit in pr #74 but from a new fork so there aren't any merge conflicts.
Also added the option to provide a list of colors to show a gradient instead of the active color background.