-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text and background color #90
Conversation
Hello, please this is exactly what I wanted. I'm a flutter beginner, please how can I implement this in my project. This changes you've made. I also need an active Background color |
THIS IS THE ERRORS IM GETTING lib/screens/home/bottom_navigator.dart:92:13: Error: No named parameter with the name 'activeBackgroundColor'. ^^^^^^^^^^^^^^^^^ |
Hello, |
Okay I understand. But please can you show me how I can Add this manually? |
Hey @pedromassango, could you check this PR and merge it if everything is ok please? :) Thanks in advance ! |
Thanks for the contributions and sorry for being late. I am now in charge of this package, I will be reviewing this PR very soon. |
0953e7c
to
cad3a33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Added some fixes.
Now with
activeTextColor
, you can separately control icon and text color. I had implementedactiveBackgroundColor
, so you can even control background color separated from icon and text color. These are optional fields, so compatibility will be maintained.This PR can close both issues #65 and #52.