Change incorrect WebSocket reference to Unix sockets #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that the reference to WebSockets is incorrect in the book. I think that this is not actually WebSockets but instead a standard Unix socket abstraction. Normally, WebSockets is a protocol for establishing a two-way communication to a backend webserver (after performing a HTTP upgrade). In the book, only the normal request and response flow is shown. [1] https://en.wikipedia.org/wiki/WebSocket [2] https://en.wikipedia.org/wiki/Berkeley_sockets#Socket_API_functions Once again, thank you for writing this book. I assign the copyright of this contribution to Pedro Duarte Faria.
|
I am sorry that I made some extra line ending changes (windows vs unix). I tried multiple ways to get ride of them. You are very welcome to edit my PR. |
|
It's okay. I have faced this same issue of windows line endings vs linux multiple times, is really annoying . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that the reference to WebSockets is incorrect in the book. I think that this is not actually WebSockets but instead a standard Unix socket abstraction.
Normally, WebSockets is a protocol for establishing a two-way communication to a backend webserver (after performing a HTTP upgrade).
In the book, only the normal request and response flow is shown.
[1] https://en.wikipedia.org/wiki/WebSocket
[2] https://en.wikipedia.org/wiki/Berkeley_sockets#Socket_API_functions
Once again, thank you for writing this book.
I assign the copyright of this contribution to Pedro Duarte Faria.