-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Daylight saving #301
fix: Daylight saving #301
Conversation
Hi @dhedlund, could you please take a moment to review this PR? I would greatly appreciate your feedback. Thank you! |
Hello @dimakula yeah you could I'll rebase mine once it's done |
@dimakula done ;) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 96.41% 96.57% +0.15%
==========================================
Files 21 21
Lines 502 496 -6
==========================================
- Hits 484 479 -5
+ Misses 18 17 -1 ☔ View full report in Codecov by Sentry. |
@Matsa59 Thanks! Will work on getting a release out for this fix. |
Same fix as #229 up to date with a simple shift std apply on shift_time to keep the same hour in the timezone.
Tests were copied/pasted all credit must be give to @davec82
Edit:
Btw it resolves the TODO
investigate and fix DST bugs when using zoned DateTime