Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Daylight saving #301

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

Matsa59
Copy link
Contributor

@Matsa59 Matsa59 commented Nov 22, 2023

Same fix as #229 up to date with a simple shift std apply on shift_time to keep the same hour in the timezone.

Tests were copied/pasted all credit must be give to @davec82

Edit:

Btw it resolves the TODO investigate and fix DST bugs when using zoned DateTime

@Matsa59
Copy link
Contributor Author

Matsa59 commented Dec 21, 2023

Hi @dhedlund, could you please take a moment to review this PR? I would greatly appreciate your feedback. Thank you!

@dimakula
Copy link
Contributor

dimakula commented Jan 3, 2024

Hey @Matsa59, I'm going to attempt to get this merged to main. I'm thinking of merging #229 first so we can attribute the tests to @davec82. Once that's done, can you rebase your work off of the new main?

@Matsa59
Copy link
Contributor Author

Matsa59 commented Jan 3, 2024

Hello @dimakula yeah you could I'll rebase mine once it's done

@dimakula
Copy link
Contributor

dimakula commented Jan 3, 2024

@Matsa59 the changes from #229 are merged, you can perform the rebase and we'll merge your changes when you're done 🙂

@Matsa59
Copy link
Contributor Author

Matsa59 commented Jan 3, 2024

@dimakula done ;)

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7fee206) 96.41% compared to head (29e618f) 96.57%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   96.41%   96.57%   +0.15%     
==========================================
  Files          21       21              
  Lines         502      496       -6     
==========================================
- Hits          484      479       -5     
+ Misses         18       17       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dimakula dimakula merged commit e497f58 into peek-travel:main Jan 3, 2024
7 checks passed
@dimakula
Copy link
Contributor

dimakula commented Jan 3, 2024

@Matsa59 Thanks! Will work on getting a release out for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants