fix: Turn of TS's exactOptionalPropertyTypes

peerigon · Dec 11, 2024 · 4069985 · 4069985
1 parent 0557a83
commit 4069985
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/eslint/presets/typescript.test/main.ts b/eslint/presets/typescript.test/main.ts
@@ -5,6 +5,10 @@ import test from "./test.json" with { type: "json" };
 // eslint-disable-next-line @typescript-eslint/naming-convention
 const snake_case = 123;
 
+// Should not complain about missing dot-notation here since
+// we're using TS's noPropertyAccessFromIndexSignature
+process.env["SOME_ENV_VAR"] = "test";
+
 class SomeClass {
   #someProp = true;
   private someEventHandler = () => {

diff --git a/typescript/base.json b/typescript/base.json
@@ -2,7 +2,9 @@
   "compilerOptions": {
     "checkJs": true,
     "esModuleInterop": true,
-    "exactOptionalPropertyTypes": true,
+    // We decided to turn off `exactOptionalPropertyTypes` because it's too strict
+    // by complaining about too much unproblematic code. We may revisit this decision later.
+    "exactOptionalPropertyTypes": false,
     "forceConsistentCasingInFileNames": true,
     "isolatedModules": true,
     "lib": ["DOM", "ESNext"],