Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GRPH-168] Change object_id to 64 bit #236

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[GRPH-168] Change object_id to 64 bit #236

wants to merge 2 commits into from

Conversation

srpatel19590
Copy link

object_id is changed to 64 bit and relevant changes.

Note: It requires FC: peerplays-network/peerplays-fc#10

@pbattu123 pbattu123 self-requested a review December 6, 2019 16:18
pbattu123
pbattu123 reviewed Feb 13, 2020
View reviewed changes
Copy link

@pbattu123 pbattu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require changes from jslib too, so I would prefer to wait and combined with required 32 to 64 bit version changes. Anyway, It will take another 10+years to reach that maximum value.

@pbattu123 pbattu123 added the address in future release Need to address it in future releases based on priority, not required for present release label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbattu123 pbattu123 pbattu123 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
address in future release Need to address it in future releases based on priority, not required for present release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srpatel19590 @pbattu123