Skip to content

Commit

Permalink
1.22 changes were missing new requirement: pathType (#373)
Browse files Browse the repository at this point in the history
* Include `pathType`  in all Ingress paths, regardless of beta vs v1 apiVersion
  * beta Ingress would default to `ImplementationSpecific` if not provided, v1 now requires `pathType` to be set. Using `ImplementationSpecific` to maintain default behavior

Co-authored-by: tandz <[email protected]>
  • Loading branch information
zitikay and tandz authored Jan 10, 2022
1 parent 2e9393e commit a559353
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
3 changes: 2 additions & 1 deletion charts/pega/templates/_pega-aks-ingress.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ spec:
- host: {{ template "domainName" dict "node" .node }}
http:
paths:
- backend:
- pathType: ImplementationSpecific
backend:
{{ include "ingressService" . | indent 10 }}
---
{{- end }}
10 changes: 7 additions & 3 deletions charts/pega/templates/_pega-eks-ingress.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,15 @@ spec:
{{ if (.node.service.domain) }}
- http:
paths:
- backend:
- pathType: ImplementationSpecific
backend:
{{ include "ingressServiceSSLRedirect" . | indent 10 }}
{{ else }}
{{ if ( include "ingressTlsEnabled" . ) }}
- http:
paths:
- backend:
- pathType: ImplementationSpecific
backend:
{{ include "ingressServiceSSLRedirect" . | indent 10 }}
{{ end }}
{{ end }}
Expand All @@ -59,10 +61,12 @@ spec:
paths:
{{ if and .root.Values.constellation (eq .root.Values.constellation.enabled true) }}
- path: /c11n
pathType: ImplementationSpecific
backend:
{{ include "ingressServiceC11n" . | indent 10 }}
{{ end }}
- backend:
- pathType: ImplementationSpecific
backend:
{{ include "ingressService" . | indent 10 }}
---
{{- end }}
4 changes: 3 additions & 1 deletion charts/pega/templates/_pega-gke-ingress.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ spec:
paths:
{{ if and .root.Values.constellation (eq .root.Values.constellation.enabled true) }}
- path: /c11n
pathType: ImplementationSpecific
backend:
{{ include "ingressServiceC11n" . | indent 10 }}
{{ end }}
- backend:
- pathType: ImplementationSpecific
backend:
{{ include "ingressService" . | indent 10 }}
---
{{- end }}
4 changes: 3 additions & 1 deletion charts/pega/templates/_pega-k8s-ingress.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ spec:
paths:
{{ if and .root.Values.constellation (eq .root.Values.constellation.enabled true) }}
- path: /c11n
pathType: ImplementationSpecific
backend:
{{ include "ingressServiceC11n" . | indent 10 }}
{{ end }}
- backend:
- pathType: ImplementationSpecific
backend:
{{ include "ingressService" . | indent 10 }}
---
{{- end }}

0 comments on commit a559353

Please sign in to comment.