Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fb supplementalgroups mod #660

Closed
wants to merge 6 commits into from
Closed

Fb supplementalgroups mod #660

wants to merge 6 commits into from

Conversation

pegatim
Copy link

@pegatim pegatim commented Oct 26, 2023

Please reference the issue #659, and do hit me up for comments/questions. Thanks!

@pegatim pegatim requested a review from a team as a code owner October 26, 2023 16:09
@micgoe
Copy link

micgoe commented Dec 28, 2023

I would appreciate the code owners reviewing the PR. It would be a huge benefit for us as well

MadhuriArugula
MadhuriArugula requested changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@MadhuriArugula MadhuriArugula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for the new feature.

@kishorv10
Copy link
Contributor

kishorv10 commented Apr 23, 2024 •
edited
Loading

@pegatim Issue is similar to #635 Can you take a look at it? Can this be addressed in this PR?
Looks like both the issues are related to supplementalGroups property

@kishorv10
Copy link
Contributor

@reddy-srinivas @bhowd1 @ravitejamekapega @pegasystems/searchservice Can you review the PR?

This was referenced Apr 23, 2024
Closed
Closed
This was linked to issues Apr 23, 2024
Add securityContext.supplementalGroups to deployment #659
Closed
Ability for extended securityContext configuration apart from runAsUser in pegasearch #635
Closed
@kishorv10 kishorv10 removed a link to an issue Apr 25, 2024
Ability for extended securityContext configuration apart from runAsUser in pegasearch #635
Closed
@kishorv10
Copy link
Contributor

@pegatim Issue is similar to #635 Can you take a look at it? Can this be addressed in this PR? Looks like both the issues are related to supplementalGroups property

Never mind. It looks Issue-635 is for Search and the current PR (issue-659) is for Pega chart.

@kishorv10
Copy link
Contributor

We're closing the current pull request in favor of #750

@kishorv10 kishorv10 closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhuriArugula MadhuriArugula MadhuriArugula requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add securityContext.supplementalGroups to deployment
4 participants
@pegatim @micgoe @kishorv10 @MadhuriArugula