Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #35

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Modernize #35

merged 6 commits into from
Oct 10, 2024

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Oct 9, 2024

This is a major refactor, with big, breaking changes:

  • Switch to ES6.
  • Flat configs are now the only supported approach.
  • Added @eslint/json and @eslint/markdown.
  • Clarified the commonjs/module approaches.

hildjj added 4 commits October 9, 2024 10:04
- Moved to ES6 module, in preparation for pulling
in "@eslint/json" and other modern plugins.

- Removed all non-flat configurations.  They would
stop working soon anyway, and the warnings are
pretty loud.

- Made all flat configs export arrays.

- Made the commonjs/module split more apparent.
Incorporate feedback from trying this on the peggy
codebase.
@hildjj hildjj requested a review from Mingun October 9, 2024 18:54
@hildjj
Copy link
Contributor Author

hildjj commented Oct 9, 2024

@Mingun I put you as a reviewer so that you're aware of the changes. I'll handle all of the down-stream issues in the peggy repos.

@hildjj
Copy link
Contributor Author

hildjj commented Oct 10, 2024

Since there is not substantive change to the coding standards, I'm going to assume nobody minds the changes and land this.

@ me on this issue if anyone needs help dealing with the consequences.

@hildjj hildjj merged commit cdc1e9d into peggyjs:main Oct 10, 2024
3 checks passed
@hildjj hildjj deleted the modernize branch October 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant