Merge pull request #1480 from stevelacy/slop-4

Increase slop to 4 on `address_parts.street` field
pelias · Aug 7, 2020 · befe777 · befe777
2 parents 7453a5d + 9eb450e
commit befe777
Show file tree

Hide file tree

Showing 13 changed files with 15 additions and 15 deletions.
diff --git a/query/search_defaults.js b/query/search_defaults.js
@@ -44,7 +44,7 @@ module.exports = _.merge({}, peliasQuery.defaults, {
   'address:street:analyzer': 'peliasQuery',
   'address:street:field': 'address_parts.street',
   'address:street:boost': 5,
-  'address:street:slop': 3,
+  'address:street:slop': 4,
   'address:street:cutoff_frequency': 0.01,
 
   'address:postcode:analyzer': 'peliasZip',

diff --git a/test/unit/fixture/search_boundary_country.js b/test/unit/fixture/search_boundary_country.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_boundary_country_multi.js b/test/unit/fixture/search_boundary_country_multi.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_boundary_gid.js b/test/unit/fixture/search_boundary_gid.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_fallback.js b/test/unit/fixture/search_fallback.js
@@ -111,7 +111,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   },
@@ -279,7 +279,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   },

diff --git a/test/unit/fixture/search_linguistic_bbox.js b/test/unit/fixture/search_linguistic_bbox.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_linguistic_focus.js b/test/unit/fixture/search_linguistic_focus.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_linguistic_focus_bbox.js b/test/unit/fixture/search_linguistic_focus_bbox.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_linguistic_focus_null_island.js b/test/unit/fixture/search_linguistic_focus_null_island.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_linguistic_only.js b/test/unit/fixture/search_linguistic_only.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_with_category_filtering.js b/test/unit/fixture/search_with_category_filtering.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/fixture/search_with_source_filtering.js b/test/unit/fixture/search_with_source_filtering.js
@@ -15,7 +15,7 @@ module.exports = {
                       'address_parts.street': {
                         'query': 'street value',
                         'analyzer': 'peliasQuery',
-                        'slop': 3
+                        'slop': 4
                       }
                     }
                   }

diff --git a/test/unit/query/address_search_using_ids.js b/test/unit/query/address_search_using_ids.js
@@ -146,7 +146,7 @@ module.exports.tests.other_parameters = (test, common) => {
 
   });
 
-  test('address_parts.street slop defaults to 3', (t) => {
+  test('address_parts.street slop defaults to 4', (t) => {
     const logger = mock_logger();
 
     const clean = {
@@ -172,7 +172,7 @@ module.exports.tests.other_parameters = (test, common) => {
 
     const generatedQuery = generateQuery(clean, res);
 
-    t.deepEquals(generatedQuery.body.vs.var('address:street:slop').toString(), 3);
+    t.deepEquals(generatedQuery.body.vs.var('address:street:slop').toString(), 4);
     t.end();
   });
 };