perf: use prepared statment cache #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
commented
Mar 12, 2020
| @@ -34,7 +34,7 @@ | |||
| "jsftp": "^2.0.0", | |||
| "lodash": "^4.17.4", | |||
| "morgan": "^1.9.0", | |||
| "node-postal": "^1.0.0", | |||
| "node-postal": "https://github.com/imothee/node-postal.git", | |||
There was a problem hiding this comment.
hmm, I needed this for testing nodejs@v12, @orangejulius what should we do about this?
it's only tangentially related to the PR
There was a problem hiding this comment.
I think it's fine to merge it. I hadn't merged it yet because I figured we'd be merging #146, but its been a while now and Node.js 12 is still not technically supported.
missinglink
force-pushed
the
performance
branch
2 times, most recently
from
c63e638 to
93f2ef6
Compare
missinglink
force-pushed
the
performance
branch
from
93f2ef6 to
9a3115e
Compare
|
superseded by #244 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a cache for prepared statements which improves performance by ~10% at 100VUs
Typical load test results after pre-warming on my macbook:
k6 run --vus 100 --iterations 10000 test.js master iteration_duration.........: avg=55.42ms min=15.67ms med=55.18ms max=90.3ms p(90)=63.34ms p(95)=66.49ms iterations.................: 10000 1797.863942/s this PR iteration_duration.........: avg=44.16ms min=13.45ms med=43.4ms max=79.23ms p(90)=47.22ms p(95)=49.71ms iterations.................: 10000 2253.759616/s