feat(package): use node-postal module compatible with node12 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
node-postal-12
branch
from
ea796a9 to
665151a
Compare
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Mar 13, 2020
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between [node-postal and Node.js 12](openvenues/node-postal#24). We are now using a Node.js 12 compatible fork of the `node-postal` libary, so we can now bring the libpostal baseimage back to parity with the other Docker images. This will reduce complexity, maintenance times, and download sizes for Pelias containers. Connects pelias/interpolation#245 Connects pelias/pelias#800
orangejulius
added a commit
to pelias/docker-libpostal_baseimage
that referenced
this pull request
Mar 13, 2020
The libpostal baseimage has historically stayed on the Node.js 10 branch of the Pelias base image due to incompatibility between [node-postal and Node.js 12](openvenues/node-postal#24). We are now using a Node.js 12 compatible fork of the `node-postal` libary, so we can now bring the libpostal baseimage back to parity with the other Docker images. This will reduce complexity, maintenance times, and download sizes for Pelias containers. Connects pelias/interpolation#245 Connects pelias/pelias#800
|
Oh, I thought it was either 10 or 12. Build matrix shows this works with both, so I'm 👍 👍. Although I think linking to a master branch could mean unexpected changes in the future, maybe we can either fork this code to something we control or pin a specific commit? |
|
Good call, I'll pin to the latest commit. |
This updates our dependencies to use the Node.js 12 (and 10) compatible fork of [node-postal](https://github.com/openvenues/node-postal). The fork is located at [imothee/node-postal](https://github.com/imothee/node-postal). Connects pelias/pelias#800
orangejulius
force-pushed
the
node-postal-12
branch
from
665151a to
8d6ff7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from other recent PRs. This allows us to support actually running the interpolation service on Node.js 12
If we end up merging something like #146 which unbundles the libpostal service from this repo, then we won't not need this any more, but it's a small enough change that it's worth it.
Connects pelias/pelias#800