feat(logging): reduce log verbosity #279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple, partial fix for the issue mentioned in #278
this PR simply changes the logger to write only the error message and not the whole stack.
the log files contain many entries such as the one below, the stack itself isn't useful and the corresponding line number can be found easily with
git grep 'invalid csv row'
as its the only occurrence in the repo.I expect that this minor change will significantly reduce the log size, at least for addresses with an empty
NUMBER
orSTREET
field.there's still way more we can do to mitigate #278, I suspect that developers rarely even read these logs, so maybe configuring the verbosity and only enabling high verbosity during local development would be preferable.