Skip to content

Commit

Permalink
Merge pull request #549 from pelias/nodejs-18-and-ci-updates
Browse files Browse the repository at this point in the history
Update CI to conform to a standard template and test all supported, non-EOL LTS Node.js releases
  • Loading branch information
orangejulius authored Nov 29, 2024
2 parents 47ba170 + 6792240 commit e9214fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,8 @@ jobs:
strategy:
matrix:
os:
- ${{ vars.UBUNTU_VERSION }}
node-version:
- 12.x
- 14.x
- 16.x
- 18.x
- ubuntu-22.04
node-version: [ 18.x, 20.x ]
steps:
- uses: actions/checkout@v4
- name: 'Install node.js ${{ matrix.node-version }}'
Expand All @@ -20,5 +16,6 @@ jobs:
node-version: '${{ matrix.node-version }}'
- name: Run unit tests
run: |
[[ -f ./bin/ci-setup ]] && ./bin/ci-setup
npm install
npm run ci
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
npm-publish:
needs: unit-tests
if: github.ref == 'refs/heads/master' && needs.unit-tests.result == 'success'
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Install Node.js
Expand All @@ -26,7 +26,7 @@ jobs:
# note: github actions won't run a job if you don't call one of the status check functions, so `always()` is called since it evalutes to `true`
if: ${{ always() && needs.unit-tests.result == 'success' && (needs.npm-publish.result == 'success' || needs.npm-publish.result == 'skipped') }}
needs: [unit-tests, npm-publish]
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Build Docker images
Expand Down

0 comments on commit e9214fb

Please sign in to comment.