Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node Updating #316

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix Node Updating #316

merged 2 commits into from
Jun 7, 2024

Conversation

lancepioch
Copy link
Member

No description provided.

@lancepioch lancepioch self-assigned this Jun 3, 2024
@notAreYouScared
Copy link
Member

notAreYouScared commented Jun 3, 2024 •
edited
Loading

When the daemon key is rotated, the new token_id & token are not sent to wings.

@Boy132
Copy link
Member

Boy132 commented Jun 6, 2024 •
edited
Loading

When the daemon key is rotated, the new token_id & token are not sent to wings.

That's why the cloning is needed, to make sure it updates properly.

We need to add the node id to the cloned node and set exists to true so it's not saved as new node. That should will fix it.
grafik

@notAreYouScared notAreYouScared merged commit 9ce262b into main Jun 7, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@Boy132 Boy132 deleted the issue/node-update branch October 1, 2024 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notAreYouScared notAreYouScared notAreYouScared approved these changes

Assignees

@lancepioch lancepioch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lancepioch @notAreYouScared @Boy132