Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create Database btn on admin side #721

Merged
merged 24 commits into from
Dec 1, 2024
Merged

Conversation

notAreYouScared
Copy link
Member

Adds a Create Database button to edit server page to allow admins to create databases on the users behalf, checks for database hosts and if the server has database feature allocations.

@notAreYouScared notAreYouScared added the ✨ feature New feature label Nov 20, 2024
@notAreYouScared notAreYouScared self-assigned this Nov 20, 2024
@lancepioch lancepioch removed their request for review November 20, 2024 02:41
Copy link
Contributor

@RMartinOscar RMartinOscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't check for Database limit like it did on Pterodactyl (don't know if its intentional)
image
databaseHost can be not suitable (dbHost is set to an other node then the one the server has) for this server and it will still create
Also would be nice if the first databaseHost it could find would be selected by default
Delete button doesn't ask for a confirmation

@notAreYouScared
Copy link
Member Author

Doesn't check for Database limit like it did on Pterodactyl (don't know if its intentional).
Correct, Admins are not limited by the servers feature limit, It will create it if the server does not have enough.

databaseHost can be not suitable (dbHost is set to an other node then the one the server has) for this server and it will still create

Also would be nice if the first databaseHost it could find would be selected by default

Its wonky and we found a filament bug as i tried to use ->selectableplaceholder(false) to remove the place holder but the first option is still returned as null so you'd never be able to use the first option in the dropdown.

@RMartinOscar
Copy link
Contributor

Its wonky and we found a filament bug as i tried to use ->selectableplaceholder(false) to remove the place holder but the first option is still returned as null so you'd never be able to use the first option in the dropdown.

SDhoudl be able to use default like we did on the CreateServer page

->default(fn () => ($this->node = Node::query()->latest()->first())?->id)

@notAreYouScared notAreYouScared dismissed stale reviews from RMartinOscar and Boy132 November 30, 2024 15:44

Re-review

@notAreYouScared notAreYouScared merged commit cd448cd into main Dec 1, 2024
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
@Boy132 Boy132 deleted the feature/create-db branch December 6, 2024 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants