Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

azure pipeline agent #2046

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YannickFuereder
Copy link

@YannickFuereder YannickFuereder commented Jan 7, 2023

Description

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?

@QuintenQVD0
Copy link
Collaborator

QuintenQVD0 commented Jan 7, 2023

I see a lot of no goos. Script as startup, hardlock the versions, not using the github release grab scripts, if dotnet is needed for instalation use a pre build container image for that.

@QuintenQVD0
Copy link
Collaborator

You missed all readme's

@YannickFuereder
Copy link
Author

its not possible to use a github release grab script because all other releases use a different dotnet version etc

@QuintenQVD0
Copy link
Collaborator

Also you need dotnet in the install script but not in the game server?

@QuintenQVD0
Copy link
Collaborator

QuintenQVD0 commented Jan 8, 2023

also this

echo "-----------------------------------------"
echo "Installation completed"
echo "-----------------------------------------"

should only be used at the end of the install script not somewhere in between

  • the native support arm64 so please also integrate that

@QuintenQVD0
Copy link
Collaborator

@YannickFuereder I made a commit to this PR. Please test it out for me and show me the install logs. If the install fails due to there not being dotnet then and only then change the install image to bitnami/dotnet-sdk:6-debian-11 and reinstall

@YannickFuereder
Copy link
Author

another issue occured while testing

the agent need root permissions
aka sudo ./run.sh

how do i do that?

i think i got time for testing your commit today

@gOOvER
Copy link
Contributor

gOOvER commented Jan 13, 2023

another issue occured while testing

the agent need root permissions aka sudo ./run.sh

how do i do that?

i think i got time for testing your commit today

you cant run root in a container.

@QuintenQVD0
Copy link
Collaborator

another issue occured while testing

the agent need root permissions aka sudo ./run.sh

how do i do that?

i think i got time for testing your commit today

As goover stated, not. If it is required, then this will not work. Likely it is just a check in the script. As we do not support running a script as the startup and running the bin directly will likely work, if not then this will not run in pterodactl

@YannickFuereder
Copy link
Author

fixed your install script

this somehow also fixed my root problem

everything seems to work fine

are there still any issues?

@QuintenQVD0
Copy link
Collaborator

What was wrong with the install script? It worked fine. Also it will not be merged with the startup as a script that is easy a no go

@QuintenQVD0
Copy link
Collaborator

Also wy do you need dotnet in the install script but not in the game container?

@YannickFuereder
Copy link
Author

you missed an apt update, and you updated export AGENT_ALLOW_RUNASROOT="1" to AGENT_ALLOW_RUNASROOT="0"
this has to be 1 otherwhise the agent wont start the configuration

i need dotnet in my game container as well
which image should i use?

i'm going to write a startup command that should work for all version

@QuintenQVD0
Copy link
Collaborator

you missed an apt update, and you updated export AGENT_ALLOW_RUNASROOT="1" to AGENT_ALLOW_RUNASROOT="0" this has to be 1 otherwhise the agent wont start the configuration

i need dotnet in my game container as well which image should i use?

i'm going to write a startup command that should work for all version

ghcr.io/parkervcp/yolks:dotnet_6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants