Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Update egg-custom-re-h-l-d-s-engine-game.json 25th anniversary fix #2605

Merged
merged 3 commits into from
Dec 17, 2023

Conversation

MEEKR1T
Copy link
Contributor

@MEEKR1T MEEKR1T commented Dec 14, 2023

uses the -beta flag to select the steam_legacy version of the server, which is known to work without issue.

see rehlds/ReHLDS#999 (comment)

Description

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

uses the -beta flag to select the steam_legacy version of the server, which is known to work without issue. 

see rehlds/ReHLDS#999 (comment)
@QuintenQVD0
Copy link
Collaborator

QuintenQVD0 commented Dec 14, 2023

This pr has some wrong things.

  1. Make changes in a panel, export and fully replace the file here
  2. You can not hard set to use the beta branch
  3. You should have used our steamcmd install script logic

I fix it myself later this day. But already thanks for you pr

@QuintenQVD0 QuintenQVD0 marked this pull request as draft December 14, 2023 07:03
@QuintenQVD0 QuintenQVD0 marked this pull request as ready for review December 14, 2023 10:09
@QuintenQVD0
Copy link
Collaborator

@MEEKR1T Thank you for your PR, I made some needed changes to it. can you please test the re-hlds egg again?

@QuintenQVD0
Copy link
Collaborator

by default the default branch is still the public but you can set it to the legacy one

@webpashtet
Copy link

the server crashes after a player connects

@QuintenQVD0
Copy link
Collaborator

the server crashes after a player connects

client and server mismatched version? do you have any logs?

@webpashtet
Copy link

the server crashes after a player connects

client and server mismatched version? do you have any logs?

image
I tried to connect from the legacy version and the server also crashes

@QuintenQVD0
Copy link
Collaborator

the server crashes after a player connects

client and server mismatched version? do you have any logs?

image I tried to connect from the legacy version and the server also crashes

you have any crach / console log as with there is nothing I can do

@QuintenQVD0
Copy link
Collaborator

the server crashes after a player connects

client and server mismatched version? do you have any logs?

image I tried to connect from the legacy version and the server also crashes

I hope you made a fresh server and did not try it on an already made one

@MEEKR1T
Copy link
Contributor Author

MEEKR1T commented Dec 14, 2023

the server crashes after a player connects

Works fine for me, even when joining from the standard 25th anniversary client.
cs git

Copy link
Contributor Author

@MEEKR1T MEEKR1T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not having success in getting this to work. SteamCMD does not appear to be downloading everything, and as a result I am getting the following error:
FATAL ERROR (shutting down): W_LoadWadFile: couldn't load gfx.wad

I have tried manually adding the gfx.wad, but then it asks for another file, and another.

Also, when setting the game to "cstrike" I get the following error:
Invalid game type 'cstrike' sepecified

@QuintenQVD0
Copy link
Collaborator

I am not having success in getting this to work. SteamCMD does not appear to be downloading everything, and as a result I am getting the following error: FATAL ERROR (shutting down): W_LoadWadFile: couldn't load gfx.wad

I have tried manually adding the gfx.wad, but then it asks for another file, and another.

Also, when setting the game to "cstrike" I get the following error: Invalid game type 'cstrike' sepecified

That is normal, You need to log in to download cstrike2, steam locked it down. You need an steam account with steamguard off but it does not need to own the game

@QuintenQVD0
Copy link
Collaborator

@MEEKR1T see: #2376

there is a reason we added it

@webpashtet
Copy link

the server crashes after a player connects

client and server mismatched version? do you have any logs?

image I tried to connect from the legacy version and the server also crashes

I hope you made a fresh server and did not try it on an already made one

yes, I'm creating a clean hl1 server with ReHLDS

@webpashtet
Copy link

webpashtet commented Dec 14, 2023

the server crashes after a player connects

client and server mismatched version? do you have any logs?

image I tried to connect from the legacy version and the server also crashes

you have any crach / console log as with there is nothing I can do

image

custom.hpk the file does not affect the server crash. I added an empty file
image

@MEEKR1T
Copy link
Contributor Author

MEEKR1T commented Dec 14, 2023

@MEEKR1T see: #2376

there is a reason we added it

Thank you for your quick replies and advice.
In my screenshot, that instance of the server did not require me to set a steam user/pass. It just worked. I have tried making a Half-Life server (game: valve) and a CS1.6 server and neither will work even when signing in with steam.
Still getting "Invalid game type 'cstrike' sepecified" when trying to make another CS1.6 server.
Also still getting "FATAL ERROR (shutting down): W_LoadWadFile: couldn't load gfx.wad" when trying to make a Half-Life server

Again, this was with the steam username and password field configured prior to installation. SteamGuard is disabled on the account and I do see that it is having no issues with logging into my account.

I'm very confused as to why I am able to get a server running once with your egg, and then it never works again on any following attempts.

I just tried my version of the egg again (with the hardcoded beta flags) and it worked, without signing into steam, or any extra interaction. Just load up the egg, create a server, set game to cstrike, and it works.

@QuintenQVD0
Copy link
Collaborator

the server crashes after a player connects

client and server mismatched version? do you have any logs?

image I tried to connect from the legacy version and the server also crashes

you have any crach / console log as with there is nothing I can do

image

custom.hpk the file does not affect the server crash. I added an empty file image

segfault, that sounds like unraid to me to be honnest

@QuintenQVD0
Copy link
Collaborator

@MEEKR1T see: #2376
there is a reason we added it

Thank you for your quick replies and advice. In my screenshot, that instance of the server did not require me to set a steam user/pass. It just worked. I have tried making a Half-Life server (game: valve) and a CS1.6 server and neither will work even when signing in with steam. Still getting "Invalid game type 'cstrike' sepecified" when trying to make another CS1.6 server. Also still getting "FATAL ERROR (shutting down): W_LoadWadFile: couldn't load gfx.wad" when trying to make a Half-Life server

Again, this was with the steam username and password field configured prior to installation. SteamGuard is disabled on the account and I do see that it is having no issues with logging into my account.

I'm very confused as to why I am able to get a server running once with your egg, and then it never works again on any following attempts.

I just tried my version of the egg again (with the hardcoded beta flags) and it worked, without signing into steam, or any extra interaction. Just load up the egg, create a server, set game to cstrike, and it works.

To be honest, I have no idea what is happening.
We can not force set beta in the install script as there is auto update by the egg that will mess it up
You are using RE-HLDS right?
I start a server myself with the stock unmodified egg so game cstrike and see

@QuintenQVD0
Copy link
Collaborator

also you may need to reinstall 2 or 3 times as steam has issues with downloading HLDS , it always has
afbeelding

@QuintenQVD0
Copy link
Collaborator

With a steam account setup, 2 reinstalls it is just working for me

afbeelding
afbeelding
afbeelding

both cstrike and valve.
and also after a reinstall

so the issue you are having is the faild install or something is wrong with your host system, but post install logs if you can.
Your steam password will be in it
so cat the file , filter it out then share it in a paste link

@QuintenQVD0
Copy link
Collaborator

@MEEKR1T @webpashtet Please test, but it works fine for me, read also a little up in this conversation of what I sad before

@parkervcp parkervcp merged commit 2d7606f into pelican-eggs:master Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants