Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: The Lord of the Rings: Return to Moria #141

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

QuintenQVD0
Copy link
Contributor

Description

This is @gOOvER egg converted to use the variable names of our own images converted. I have his approval on this as he does not have the time to always convert his own standard to ours so I did it for him and will continue to in the future.

closes #138

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@hackles
Copy link

hackles commented Feb 22, 2025

This worked great on my end. I updated the installer to look for the config file in the lotr-moria branch in this repo. Other than that, everything worked great and I was able to connect to the server.

I noticed that the status.json file does not appear to get updated. I'm assuming that's out of our control, though.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Egg Request]: Lords of the Ring: Return to Moria
2 participants