Fix django template injection/attribute handling.

pelme · Apr 16, 2024 · 74e54f1 · 74e54f1
1 parent 2a18ee8
commit 74e54f1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/htpy/__init__.py b/htpy/__init__.py
@@ -194,6 +194,12 @@ def __iter__(self) -> Iterator[str]:
     def __repr__(self) -> str:
         return f"<{self.__class__.__name__} '{self}'>"
 
+    # Avoid having Django "call" a htpy element that is injected into a
+    # template. Setting do_not_call_in_templates will prevent Django from doing
+    # an extra call:
+    # https://docs.djangoproject.com/en/5.0/ref/templates/api/#variables-and-lookups
+    do_not_call_in_templates = True
+
 
 class Element(BaseElement):
     def __getitem__(self: ElementSelf, children: Node) -> ElementSelf:

diff --git a/tests/test_django.py b/tests/test_django.py
@@ -11,9 +11,9 @@
 
 def test_template_injection() -> None:
     t = Template("<ul>{{ stuff }}</ul>")
-    result = t.render(Context({"stuff": li["I am safe!"]}))
+    result = t.render(Context({"stuff": li(id="hi")["I am safe!"]}))
 
-    assert result == "<ul><li>I am safe!</li></ul>"
+    assert result == '<ul><li id="hi">I am safe!</li></ul>'
 
 
 def test_SafeString() -> None: