Update Dag Factory to use active flag #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryYin1777
reviewed
Mar 6, 2024
| @@ -1,2 +1,2 @@ | |||
| """Module contains the version of dag-factory""" | |||
| __version__ = "0.17.1.post11" | |||
| __version__ = "0.17.1.post12" | |||
There was a problem hiding this comment.
could you use post13 if you don't mind? I'm pushing in an emergency fix today that will use post12
| @@ -1,7 +1,8 @@ | |||
| import logging | |||
| import os | |||
There was a problem hiding this comment.
not a big deal but it's not really necessary to update this class. dag factory actually imports from the airflow repo at run time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PR
Create attribute
is_dag_activein Dag Builder so that Airflow can sync status