fix the audio format specification sdl-1.2 is using for 8-bit android audio #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 8-bit audio data format that Android audio actually supports and works if you deliver bytes in that format here is not
AUDIO_S8(8-bit two's complement signed values) but ratherAUDIO_U8(8-bit offset binary values, what is normally called "unsigned"), so let's use that format ID.If you don't want to have to change IDs in whatever else is using your sdl-1.2 all at once, you could instead keep
AUDIO_S8in the||list as well asAUDIO_U8, and take it out once the changeover of everything else is complete.Goes with the other pull request for pelya/BasiliskII-android#7