Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to convert Kotlin Lingua to Java Lingua #234

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

azagniotov
Copy link

Context

@pemistahl Peter,

After coming across the:

I decided to give it a go and lend a hand, or two. I do realize that without knowing your own progress with the #214, my effort may be a futile effort. But, I still decided to jump in.

I understand that you may be busy with real life and a young family, so whenever you have some feedback, I will really appreciate it. At this point, I would like to ask you how is it looking so far. Also, please let me know if you have any concerns. In any way, should there be any issues where I should not proceed further, I am happy to close the PR.

Thank you.

The State of Things

What has been migrated/achieved

  • build.gradle has been migrated in order to build the project and run the tests
  • The commits on the PR are atomic enough, so I hope this will enable you to review this with more ease.
  • All the migrated test cases pass (apart from what has been outlined in Concerns so far below)
  • Gradle plugin 'com.github.sherter.google-java-format' was added to help with formatting, e.g.: ./gradlew googleJavaFormat

What has not been migrated/achieved

  • build.gradle artifact packaging, reporting and publishing still need to be tested out
  • api package: LanguageDetector and LanguageDetectorBuilder, plus their respective tests
  • accuracyReport package classes
  • internal.io package classes

Concerns so far

  • The test TrainingDataLanguageModelTest.assertThatUnigramLanguageModelIsCorrectlySerializedToJson is failing because the obtained JSON object keys are not in the same order as the expected JSON. Therefore JSON object string comparison fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant