An attempt to convert Kotlin Lingua to Java Lingua #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
@pemistahl Peter,
After coming across the:
I decided to give it a go and lend a hand, or two. I do realize that without knowing your own progress with the #214, my effort may be a futile effort. But, I still decided to jump in.
I understand that you may be busy with real life and a young family, so whenever you have some feedback, I will really appreciate it. At this point, I would like to ask you how is it looking so far. Also, please let me know if you have any concerns. In any way, should there be any issues where I should not proceed further, I am happy to close the PR.
Thank you.
The State of Things
What has been migrated/achieved
build.gradle
has been migrated in order to build the project and run the testsConcerns so far
below)'com.github.sherter.google-java-format'
was added to help with formatting, e.g.:./gradlew googleJavaFormat
What has not been migrated/achieved
build.gradle
artifact packaging, reporting and publishing still need to be tested outapi
package:LanguageDetector
andLanguageDetectorBuilder
, plus their respective testsaccuracyReport
package classesinternal.io
package classesConcerns so far
TrainingDataLanguageModelTest.assertThatUnigramLanguageModelIsCorrectlySerializedToJson
is failing because the obtained JSON object keys are not in the same order as the expected JSON. Therefore JSON object string comparison fails.