Add protection in Instanced_Markup_Mesh::update_instancing_buffers()

If balls is empty, don't run glBufferSubData().
pemsley · Jan 7, 2025 · 10f9720 · 10f9720
1 parent 990078d
commit 10f9720
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Instanced-Markup-Mesh.cc b/src/Instanced-Markup-Mesh.cc
@@ -233,8 +233,10 @@ Instanced_Markup_Mesh::update_instancing_buffers(const std::vector<Instanced_Mar
    if (n_instances > max_n_instances)
       n_instances = max_n_instances;
 
-   glBindBuffer(GL_ARRAY_BUFFER, inst_attribs_buffer_id);
-   glBufferSubData(GL_ARRAY_BUFFER, 0, n_instances * sizeof(Instanced_Markup_Mesh_attrib_t), &(balls[0]));
+   if (n_instances > 0) {
+      glBindBuffer(GL_ARRAY_BUFFER, inst_attribs_buffer_id);
+      glBufferSubData(GL_ARRAY_BUFFER, 0, n_instances * sizeof(Instanced_Markup_Mesh_attrib_t), &(balls[0]));
+   }
 
 }