Skip to content

Commit

Permalink
Always generate debug info in Visual Studio
Browse files Browse the repository at this point in the history
  • Loading branch information
@chchwy
chchwy committed Jul 2, 2020
1 parent 0738cac commit 91f0b97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common.pri
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ win32-msvc* {
CONFIG(release) {
QMAKE_CXXFLAGS += /Gy /GL
CONFIG += ltcg
#CONFIG += force_debug_info
CONFIG += force_debug_info

This comment has been minimized.

Sign in to view

Copy link
@scribblemaniac

scribblemaniac Jul 3, 2020

Member

This seems like a bad idea. Releases shouldn't have debug information in them at all. What's the point of using a release configuration if you're just going to add all the debug info back in?

This comment has been minimized.

Sign in to view

Copy link
@chchwy

chchwy Jul 4, 2020

Author Member

Debug info is in a separated file called pencil2d.pdb so it basically has no impact on the executable. Users won't notice any differences If we don't put that pdb file in the zip.

Debug info is extremely useful that I can see the variables and call stack when the app crashes. That's how I QA pencil2d on my machine.

This comment has been minimized.

Sign in to view

Copy link
@chchwy

chchwy Jul 4, 2020

Author Member

Also, I have an idea in my mind about uploading crash reports when the app crashes. It will need the debug info when compiling. Generally I think it's good to have debug info anytime. I added in MSVC only because I know how it works.
}
}

Expand Down

0 comments on commit 91f0b97

Please sign in to comment.