Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly build download page #23

Merged
merged 16 commits into from
Nov 19, 2021

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Sep 21, 2021

In the past we talked about how the Google Drive interface isn’t that nice for our Nightly Builds. So with that in mind I sat down today and made a custom interface that fetches the file list from Google Drive and the workflow runs from GitHub and combines that information into a nice overview. The interface isn’t particularly fancy, but IMO it’s still better than what we have now. The code also isn’t particularly fancy but I’d say it’s not particularly ugly either. No dependencies, just plain old JavaScript.

Screen Shot 2021-09-21 at 20 39 16

Resolves pencil2d/pencil#1153 (I think?)

@Jose-Moreno
Copy link
Member

Jose-Moreno commented Sep 21, 2021

That's great! nice job @J5lx A few questions, so each link would be a nightly build with the respective commit message that triggered that build? also what will happen when the google drive nightly builds are cleaned?

FYI after a certain amount of builds, chchwy has a script that erases the oldest ones if I'm not mistaken, so what will happen in that page? will it always stay up to date with the current nightly builds? or will it leave a history?

While it would be nice to have a history of the nightly builds, since those links get deleted with time, for presentation purposes it would be better if the actual links only reflect what the google drive folder has at any given time. I assume that since you're only fetching the list this won't happen, but I just want to be sure. Thoughts?

@J5lx
Copy link
Member Author

J5lx commented Sep 21, 2021

Yes, the description is from the commit that triggered the build, and it is linked to the commit on GitHub.

You’re correct about the data “freshness” as well. The list is always compiled on-the-fly based on the latest data from GitHub and Google Drive, so it won’t become outdated.

@scribblemaniac scribblemaniac force-pushed the features/nightly-build-page branch 2 times, most recently from 914ef4e to 12d3867 Compare November 11, 2021 05:35
@scribblemaniac
Copy link
Member

Sorry but I have only just seen this today. I love the idea and it is working well with the exception of the occasional "Unable to retrieve information". I have fixed this and added some other things I think would improve the page in a PR (J5lx#1). Once that PR is merged, I think this PR will be ready to merge as well.

The only things I think could be improved that are not included here nor in my PR are:

  • An occasional refresh of the list (even just a couple times a day) in case a user feels leaves it open and expects to have the latest data.
  • UI improvements for downloading the latest build from the nightly builds page. The vast majority of users are going to want to download the latest build, so it would be nice if there were direct links to those builds front-and-center. I'm imagining this as being similar to the way the stable downloads look on the main downloads page.

@J5lx J5lx requested a review from scribblemaniac November 18, 2021 11:05
Copy link
Member

@scribblemaniac scribblemaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@chchwy chchwy merged commit ba799c5 into pencil2d:master Nov 19, 2021
@J5lx J5lx deleted the features/nightly-build-page branch December 10, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate alternative hosting options for nightly builds
4 participants