-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly build download page #23
Conversation
That's great! nice job @J5lx A few questions, so each link would be a nightly build with the respective commit message that triggered that build? also what will happen when the google drive nightly builds are cleaned? FYI after a certain amount of builds, chchwy has a script that erases the oldest ones if I'm not mistaken, so what will happen in that page? will it always stay up to date with the current nightly builds? or will it leave a history? While it would be nice to have a history of the nightly builds, since those links get deleted with time, for presentation purposes it would be better if the actual links only reflect what the google drive folder has at any given time. I assume that since you're only fetching the list this won't happen, but I just want to be sure. Thoughts? |
Yes, the description is from the commit that triggered the build, and it is linked to the commit on GitHub. You’re correct about the data “freshness” as well. The list is always compiled on-the-fly based on the latest data from GitHub and Google Drive, so it won’t become outdated. |
Designed to take up less space while being more human-readable. Full date and time and moved to the tooltip.
914ef4e
to
12d3867
Compare
Sorry but I have only just seen this today. I love the idea and it is working well with the exception of the occasional "Unable to retrieve information". I have fixed this and added some other things I think would improve the page in a PR (J5lx#1). Once that PR is merged, I think this PR will be ready to merge as well. The only things I think could be improved that are not included here nor in my PR are:
|
Also modified the way errors are displayed in both nightly build pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
In the past we talked about how the Google Drive interface isn’t that nice for our Nightly Builds. So with that in mind I sat down today and made a custom interface that fetches the file list from Google Drive and the workflow runs from GitHub and combines that information into a nice overview. The interface isn’t particularly fancy, but IMO it’s still better than what we have now. The code also isn’t particularly fancy but I’d say it’s not particularly ugly either. No dependencies, just plain old JavaScript.
Resolves pencil2d/pencil#1153 (I think?)