Avoid specifying sp version directly. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
reviewed
Aug 29, 2024
| @@ -14,17 +14,17 @@ exclude = ["autogenerator/*"] | |||
| serde_json = { version = '1.0.64', default-features = false, features = ["alloc"], optional = true } | |||
| serde = { version = "1.0.136", default-features = false, features = ["derive", "alloc"], optional = true } | |||
| hex = { version = "0.4", default-features = false , features = ["alloc"]} | |||
| sodalite = { version = "0.4.0" } | |||
| sodalite = { version = "0.4.0", default-features = false } | |||
There was a problem hiding this comment.
Should we add "sodalite/std" to the std array in [features] below then?
There was a problem hiding this comment.
Well, it hasn't failed but you're probably right. Let's do it for consistency.
There was a problem hiding this comment.
Actually, it seems it doesn't have any std feature!
There was a problem hiding this comment.
Doesn't that mean that the default-features = false here does not have a purpose? The only feature in sodalite seems to be the optional rand dependency. But that is possibly exactly the dependency we want to avoid here (?)
ebma
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for properly compiling pendulum runtimes for the update.