Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ntp version on sources configurable. #1698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

davidv1992
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 76.31579% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.40%. Comparing base (6a6b18c) to head (c1a52cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ntpd/src/daemon/config/ntp_source.rs 15.38% 11 Missing ⚠️
ntpd/src/daemon/config/mod.rs 73.68% 5 Missing ⚠️
ntpd/src/daemon/spawn/nts.rs 0.00% 4 Missing ⚠️
ntpd/src/daemon/spawn/nts_pool.rs 0.00% 4 Missing ⚠️
ntpd/src/daemon/keyexchange.rs 85.71% 2 Missing ⚠️
ntp-proto/src/nts_record.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
+ Coverage   81.35%   81.40%   +0.05%     
==========================================
  Files          64       64              
  Lines       19753    19945     +192     
==========================================
+ Hits        16070    16237     +167     
- Misses       3683     3708      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

#[derive(Deserialize, Debug, PartialEq, Eq, Clone)]
#[serde(deny_unknown_fields)]
pub struct StandardSource {
pub address: NtpAddress,
#[cfg(feature = "unstable_ntpv5")]
#[serde(default, deserialize_with = "deserialize_ntp_version")]
pub ntp_version: Option<NtpVersion>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably add a test here that (a) tests the config parsing and (b) checks that the source is actually spawned with that ProtocolVersion specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants