PixelCount and OLED Display #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyankchouksey
commented
Jan 23, 2019
priyankchouksey
commented
- Added a feature to count the pixels (the + and - will show the pixels in model to count segments)
- Added A new Tab OLED Display to add templates for various events.
- Implemented 128x64 display
|
Good work - I like the oled support. I won’t merge this just yet because I have a big problem - massive rework on cherrypicks between forkineye’s branch and mine. I need to find a cleaner way to keep things in sync that will probably end up in me trashing my branch and somewhat starting again from a git history perspective. On the led strip length tester - it might be easier to create a “last led” effect and have live updates to the device setup page ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.