Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axpy - Level 1 - oneMKL primitive support #3

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

kballeda
Copy link

@kballeda kballeda commented Nov 3, 2022

This PR contains support of axpy level 1 oneMKL primitive.

Copy link
Owner

@pengtu pengtu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please see the comment on Float16 type, for which we will need to investigate and come back with a long term strategy.

2. remove half types in check
@kballeda
Copy link
Author

kballeda commented Nov 4, 2022

@pengtu updated as per review suggestion. Please take a look.

@pengtu
Copy link
Owner

pengtu commented Nov 7, 2022

@pengtu updated as per review suggestion. Please take a look.

@kballeda: Looking good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants